Re: [PATCH blktests 1/2] common/null_blk: introduce _have_null_blk_feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 03, 2024 / 07:55, Bart Van Assche wrote:
> On 1/3/24 03:49, Shin'ichiro Kawasaki wrote:
> > +_have_null_blk_feature() {
> > +	grep -qe "$1" /sys/kernel/config/nullb/features
> > +}
> 
> The above test can only work if the null_blk driver is already
> loaded. Is it guaranteed that the null_blk driver is loaded when
> this function is called? Wouldn't it be better to examine the
> output of modprobe null_blk?

Thanks for the comment. I agree that it's better to check the null_blk driver
availability in the function. Will improve it in v2.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux