Re: [PATCH 3/9] block: default the discard granularity to sector size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: John Pittman <jpittman@xxxxxxxxxx>
Subject: Re: [PATCH 3/9] block: default the discard granularity to sector size
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 3 Jan 2024 08:57:29 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA+RJvhwg3YXAzSk81nMGw=_3OMo6P=XcXBUFUAXSBcyXH6gkDg@mail.gmail.com>
References: <20231228075545.362768-1-hch@lst.de> <20231228075545.362768-4-hch@lst.de> <CA+RJvhwg3YXAzSk81nMGw=_3OMo6P=XcXBUFUAXSBcyXH6gkDg@mail.gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jan 02, 2024 at 05:11:19PM -0500, John Pittman wrote:
> Hi Christoph, is there a reason you used 512 instead of SECTOR_SIZE
> from include/linux/blk_types.h?  Thanks!

To match the logical_block_size/physical_block_size/io_min
assignments just below.

References:
- provide a sane discard_granularity default
  - From: Christoph Hellwig
- [PATCH 3/9] block: default the discard granularity to sector size
  - From: Christoph Hellwig
- Re: [PATCH 3/9] block: default the discard granularity to sector size
  - From: John Pittman

Prev by Date: [PATCH for-6.8/block RFC v2] block: support to account io_ticks precisely
Next by Date: [PATCH] block: floor the discard granularity to the physical block size
Previous by thread: Re: [PATCH 3/9] block: default the discard granularity to sector size
Next by thread: [PATCH 4/9] ubd: use the default discard granularity
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]