On 12/19/23 16:05, Damien Le Moal wrote:
On 12/20/23 02:42, Bart Van Assche wrote:diff --git a/block/blk-mq.c b/block/blk-mq.c index c11c97afa0bc..668888103a47 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2922,6 +2922,13 @@ static bool blk_mq_can_use_cached_rq(struct request *rq, struct blk_plug *plug, static void bio_set_ioprio(struct bio *bio) { + /* + * Do not set the I/O priority of sequential zoned write bios because + * this could lead to reordering and hence to unaligned write errors. + */ + if (blk_bio_is_seq_zoned_write(bio)) + return;That is not acceptable as that will ignore priorities passed for async direct IOs through aio->aio_reqprio. That one is a perfectly acceptable use case and we should not ignore it.
Hi Damien, What you wrote is wrong. bio_set_ioprio() applies the I/O priority set by ionice or by the blk-ioprio cgroup policy. The above patch does not affect the priorities set via aio_reqprio. aio_reqprio is still copied in ki_ioprio and ki_ioprio is still copied into bi_ioprio by the direct I/O code. Bart.
