On 12/15/23 1:02 PM, Matthew Wilcox (Oracle) wrote: > I don't think any of this conflicts with the writeback refactoring that > Christoph has kindly taken over from me, although we might want to redo > patch 13 on that infrastructure rather than using write_cache_pages(). > That can be a later addition. > > Most of these patches verge on the trivial, converting filesystems that > just use block_write_full_page() to use mpage_writepages(). But as we > saw with Christoph's earlier patchset, there can be some "interesting" > gotchas, and I clearly haven't tested the majority of filesystems I've > touched here. > > Patches 3 & 4 get rid of a lot of stack usage on architectures with > larger page sizes; 1024 bytes on 64-bit systems with 64KiB pages. > It starts to open the door to larger folio sizes on all architectures, > but it's certainly not enough yet. > > Patch 14 is kind of trivial, but it's nice to get that simplification in. Series looks good to me: Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> -- Jens Axboe
