Hi, On (23/12/06 10:33), Julia Lawall wrote: > Hello, > > The warning is because kvfree is used to free memory that was allocated > using kmalloc; kfree would be fine. But I think that the only way you can > get to out is with bitmap being NULL, so there is no need to free it at > all. > > Furthermore, it could be safer in the long term to use different labels > for the different amounts of things that need to be freed, as done in most > other kernel code, rather than using a single label "out". [..] > Date: Wed, 6 Dec 2023 16:08:49 +0800 > From: kernel test robot <lkp@xxxxxxxxx> > To: oe-kbuild@xxxxxxxxxxxxxxx > Cc: lkp@xxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxxx> > Subject: Re: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate > bitmap memory in backing_dev_store > > BCC: lkp@xxxxxxxxx > CC: oe-kbuild-all@xxxxxxxxxxxxxxx > In-Reply-To: <20231130152047.200169-1-dongyun.liu@xxxxxxxxxxxxx> > References: <20231130152047.200169-1-dongyun.liu@xxxxxxxxxxxxx> > TO: Dongyun Liu <dongyun.liu3@xxxxxxxxx> > TO: minchan@xxxxxxxxxx > TO: senozhatsky@xxxxxxxxxxxx > TO: axboe@xxxxxxxxx > CC: linux-kernel@xxxxxxxxxxxxxxx > CC: linux-block@xxxxxxxxxxxxxxx > CC: lincheng.yang@xxxxxxxxxxxxx > CC: jiajun.ling@xxxxxxxxxxxxx > CC: ldys2014@xxxxxxxxxxx > CC: Dongyun Liu <dongyun.liu@xxxxxxxxxxxxx> > > Hi Dongyun, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on axboe-block/for-next] > [also build test WARNING on linus/master v6.7-rc4 next-20231206] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Dongyun-Liu/zram-Using-GFP_ATOMIC-instead-of-GFP_KERNEL-to-allocate-bitmap-memory-in-backing_dev_store/20231130-233042 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > patch link: https://lore.kernel.org/r/20231130152047.200169-1-dongyun.liu%40transsion.com > patch subject: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate bitmap memory in backing_dev_store This patch won't land upstream. It was NAK-ed.
