On Tue, Dec 05, 2023 at 04:34:02PM +0000, Johannes Thumshirn wrote: > On 04.12.23 18:35, Christoph Hellwig wrote: > > [...] All the existing callers are fine with > > this - not because they handle this return correctly, but because they > > never pass more than a page in. > > > Wouldn't it also be beneficial to do proper return checking in the > current callers on top of this series? I did look into that - but given how they are structured it would create an even bigger mess. Except for the nvmet zns backend they all either allocate the added page right next to them or take the output from a pin_user_pages variant.