On 12/1/23 7:04 PM, Kanchan Joshi wrote: > On 12/2/2023 7:01 AM, Jens Axboe wrote: >>> Jens already applied the latest series for the next merge. We can append >>> this or fold atop, or back it out and we can rework it for another >>> version. No rush; for your patch: >> I folded this into the original to avoid the breakage, even if it wasn't >> a huge concern for this particular issue. But it's close enough to >> merging, figured we may as well do that rather than have a fixup patch. >> >> Please check the end result, both for-next and for-6.8/block are updated >> now. > > Looks good to me. > May not matter now, so a symbolic > Reviewed-by: Kanchan Joshi <joshi.k@xxxxxxxxxxx> It still matters imho, because this thread is linked in the commit. So even for the cases where I don't amend a commit to insert reviewed-bu etc, I still think it's nice to have in the linked thread. Ditto for the fixup - it's referenced in the original commit, and the link will show you what that fixup was. -- Jens Axboe