Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "kundan.kumar" <kundan.kumar@xxxxxxxxxxx>
Subject: Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 23 Nov 2023 16:30:07 +0100
Cc: axboe@xxxxxxxxx, kbusch@xxxxxxxxxx, hch@xxxxxx, linux-block@xxxxxxxxxxxxxxx, Kanchan Joshi <joshi.k@xxxxxxxxxxx>
In-reply-to: <20231123102431.6804-1-kundan.kumar@samsung.com>
References: <CGME20231123103102epcas5p2aee268735dc9e0c357e6d3b98d16fe21@epcas5p2.samsung.com> <20231123102431.6804-1-kundan.kumar@samsung.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Nov 23, 2023 at 03:54:31PM +0530, kundan.kumar wrote:
> -	if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags)) {
> +	if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags)
> +			&& !blk_rq_is_passthrough(rq)) {

&& goes on the starting line in the kernel code style.

The rest looks good, but that stats overhead seems pretty horrible..

Follow-Ups:
- Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
  - From: Jens Axboe
- Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
  - From: Kanchan Joshi

References:
- [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
  - From: kundan.kumar

Prev by Date: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
Next by Date: Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
Previous by thread: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
Next by thread: Re: [PATCH] block: skip QUEUE_FLAG_STATS and rq-qos for passthrough io
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]