On Mon, 20 Nov 2023 at 05:31, Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> wrote: > > NR_ORDERS defines the number of page orders supported by the page > allocator, ranging from 0 to MAX_ORDER, MAX_ORDER + 1 in total. > > NR_ORDERS assists in defining arrays of page orders and allows for more > natural iteration over them. Well, the thing is, I really think we need to rename or remove "MAX_ORDER" entirely. Because as-is, that #define now has completely different meaning than it used to have for 24 years. Which is not only confusing to people who might just remember the old semantics, it's a problem for backporting (and for merging stuff, but that is a fairly temporary pain and _maybe_ this one-time device mapper thing was the only time it will ever happen) Linus