Hello, Ming. On Fri, Nov 17, 2023 at 10:35:24AM +0800, Ming Lei wrote: > blkcg_deactivate_policy() can be called after blkg_destroy_all() > returns, and it isn't necessary since blkg_destroy_all has covered > policy deactivation. Does this actually affect anything? This would matter iff a policy is deactivated for the queue between blkg_destroy_all() and the rest of the queue destruction, right? That's a really small window against very rare operations. The patch is already in and I'm not necessarily against the change but I'm curious what the motivation is. Thanks. -- tejun