Re: [PATCH v3 01/10] iov_iter: Fix some checkpatch complaints in kunit tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-11-15 at 15:49 +0000, David Howells wrote:
> Fix some checkpatch complaints in the new iov_iter kunit tests:
> 
>  (1) Some lines had eight spaces instead of a tab at the start.
> 
>  (2) Checkpatch doesn't like (void*)(unsigned long)0xnnnnnULL, so switch to
>      using POISON_POINTER_DELTA plus an offset instead.

That's because checkpatch is fundamentally stupid and
that's a false positive.

> diff --git a/lib/kunit_iov_iter.c b/lib/kunit_iov_iter.c
[]
> @@ -548,7 +548,7 @@ static void __init iov_kunit_extract_pages_kvec(struct kunit *test)
>  		size_t offset0 = LONG_MAX;
>  
>  		for (i = 0; i < ARRAY_SIZE(pagelist); i++)
> -			pagelist[i] = (void *)(unsigned long)0xaa55aa55aa55aa55ULL;
> +			pagelist[i] = (void *)POISON_POINTER_DELTA + 0x5a;

I think the original is easier to understand
or would best be replaced by a single #define
without the addition.

> @@ -626,7 +626,7 @@ static void __init iov_kunit_extract_pages_bvec(struct kunit *test)
>  		size_t offset0 = LONG_MAX;
>  
>  		for (i = 0; i < ARRAY_SIZE(pagelist); i++)
> -			pagelist[i] = (void *)(unsigned long)0xaa55aa55aa55aa55ULL;
> +			pagelist[i] = (void *)POISON_POINTER_DELTA + 0x5a;

etc...






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux