Re: [PATCH v14 12/19] scsi: scsi_debug: Add the preserves_write_order module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/23 17:13, Damien Le Moal wrote:
On 10/24/23 06:54, Bart Van Assche wrote:
  static int scsi_debug_slave_alloc(struct scsi_device *sdp)
  {
+	struct request_queue *q = sdp->request_queue;
+
  	if (sdebug_verbose)
  		pr_info("slave_alloc <%u %u %u %llu>\n",
  		       sdp->host->host_no, sdp->channel, sdp->id, sdp->lun);
+	if (sdeb_preserves_write_order)
+		q->limits.driver_preserves_write_order = true;

Nit: this could simply be:

	q->limits.driver_preserves_write_order = sdeb_preserves_write_order;

  	return 0;
  }

I will make this change.

Otherwise, looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

Thanks for the review!

Bart.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux