On 10/16/23 2:47 PM, Phillip Potter wrote:
> From: Edson Juliano Drosdeck <edson.drosdeck@xxxxxxxxx>
>
> Add missing blank lines after declarations to fix warning found by
> checkpatch.pl script.
Let's please not do this. It's fine to run checkpatch on new patches to
ensure that you don't make mistakes, but this is just useless churn.
Even worse:
> @@ -1202,6 +1204,7 @@ static int check_for_audio_disc(struct cdrom_device_info *cdi,
> {
> int ret;
> tracktype tracks;
> +
> cd_dbg(CD_OPEN, "entering check_for_audio_disc\n");
> if (!(cdi->options & CDO_CHECK_TYPE))
> return 0;
This int ret is using spaces and not a tab, why even make a newline
change and not sort that out too?
But it's all mostly moot as we should not be doing patches like this.
--
Jens Axboe
