On Wed, Oct 11, 2023 at 2:53 PM Daniel Wagner <dwagner@xxxxxxx> wrote:
>
> Hi,
>
> On Wed, Oct 11, 2023 at 11:48:32AM +0800, Yi Zhang wrote:
> > @@ -478,6 +475,10 @@ _run_test() {
> > # runs to suppress job status output.
> > set +m
> >
> > + if ! TMPDIR="$(mktemp --tmpdir -p "$OUTPUT" -d "tmpdir.${TEST_NAME//\//.}.XXX")"; then
> > + return
> > + fi
> > +
> > # shellcheck disable=SC1090
> > . "tests/${TEST_NAME}"
>
> Are you sure about the placement here? I went through the call chain
> and I figured that the TMPDIR should be set in _run_group before
> we call the 'rc' files.
Yeah, you are right, just send v2 for the change.
>
> Currently it is:
>
> _check
> _run_group
> tests/${group}/rc
> _run_test
> _call_test
> TMPDIR=...
> $test_func
>
> Thanks,
> Daniel
>
--
Best Regards,
Yi Zhang
