Re: [PATCH 07/13] sd: Translate data lifetime information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/3/23 09:58, Bart Van Assche wrote:
On 10/2/23 22:48, Avri Altman wrote:
On 10/2/23 06:11, Avri Altman wrote:
sd_setup_read_write_cmnd(struct scsi_cmnd *cmd)
                  ret = sd_setup_rw16_cmnd(cmd, write, lba, nr_blocks,
                                           protect | fua, dld);
          } else if ((nr_blocks > 0xff) || (lba > 0x1fffff) ||
-                  sdp->use_10_for_rw || protect) {
+                  sdp->use_10_for_rw || protect ||
+                  rq->write_hint != WRITE_LIFE_NOT_SET) {

Is this a typo?

I don't see a typo? Am I perhaps overlooking something?
 >
Forcing READ(6) into READ(10) because that req carries a write-hint,
Deserves an extra line in the commit log IMO.

Right, I should explain that the READ(6) command does not support write hints and hence that READ(10) is selected if a write hint is present.

(replying to my own email)

In my answer READ should be changed into WRITE.

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux