On Mon, Sep 18, 2023 at 01:05:01PM +0200, Hannes Reinecke wrote: > Use the correct mapping order in grow_dev_page() to ensure folios > are created with the correct order. I see why you did this, but I think it's fragile. __filemap_get_folio() will happily decrease 'order' if memory allocation fails. I think __filemap_get_folio() needs to become aware of the minimum folio order for this mapping, and then we don't need this patch. Overall, I like bits of this patchset and I like bits of Pankaj's ;-)