On Fri, Sep 15, 2023 at 09:51:28AM +0000, Daniel Gomez wrote: > In preparation for high order folio support for the write path, add > order parameter when allocating a folio. This is on the write path > when huge support is not enabled or when it is but the huge page > allocation fails, the fallback will take advantage of this too. > static struct folio *shmem_alloc_and_acct_folio(gfp_t gfp, struct inode *inode, > - pgoff_t index, bool huge) > + pgoff_t index, bool huge, unsigned int *order) I don't understand why you keep the 'huge' parameter when you could just pass PMD_ORDER. And I don't understand why you're passing a pointer to the order instead of just passing the order.