Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 28, 2023 at 08:14:09AM -0700, Bart Van Assche wrote:
> On 8/22/23 01:38, Daniel Wagner wrote:
> > +	while [[ $# -gt 0 ]]; do
> > +		case $1 in
> > +			--blkdev)
> > +				blkdev_type="$2"
> > +				shift 2
> > +				;;
> > +			--ctrlkey)
> > +				ctrlkey="$2"
> > +				shift 2
> > +				;;
> > +			--hostkey)
> > +				hostkey="$2"
> > +				shift 2
> > +				;;
> > +			*)
> > +				shift
> > +				;;
> > +		esac
> > +	done
> 
> So all arguments that are not recognized are ignored? That will
> make debugging typo's harder than necessary. Shouldn't this function
> complain if an unrecognized argument is encountered?

Sure, I'll add a warning.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux