On 8/21/23 00:35, chengming.zhou@xxxxxxxxx wrote:
2. __blk_mq_tagset_busy_iter() has BT_TAG_ITER_STARTED flag set, so only
started requests will be iterated, which should be more efficient.
The above motivation sounds wrong to me. The goal here should be not to
change the behavior of blk_mq_queue_tag_busy_iter(). Although
blk_mq_queue_tag_busy_iter() iterates over more requests than only started
requests, apparently blk_mq_queue_tag_busy_iter() is only used to iterate
over started requests (blk_mq_request_started()). Please mention this in
the patch description.
Thanks,
Bart.
