On 8/15/23 19:06, Johannes Thumshirn wrote:
> On 08.08.23 19:56, Damien Le Moal wrote:
>> +#define ldm_debug(f, a...) pr_debug("%s(): " f, __func__, ##a) +#define
>> ldm_crit(f, a...) pr_crit("%s(): " f, __func__, ##a) +#define
>> ldm_error(f, a...) pr_err("%s(): " f, __func__, ##a) +#define
>> ldm_info(f, a...) pr_info("%s(): " f, __func__, ##a)
>
> Is there any value in keeping these ldm_XXX() macros around, other than
> printing the function name?
You named it: I didn't want to change the messages.
I do not mind simplifying these by removing the function name, but if we do not,
then the macros actually simplify the print calls.
>
> I'd just get rid of them as well and replace with the according pr_XXX()
> calls.
--
Damien Le Moal
Western Digital Research
