Re: [dm-devel] [PATCH v14 04/11] block: add emulation for copy

To: Nitesh Shetty <nj.shetty@xxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, Keith Busch <kbusch@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Chaitanya Kulkarni <kch@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>
Subject: Re: [dm-devel] [PATCH v14 04/11] block: add emulation for copy
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Fri, 11 Aug 2023 15:11:05 -0700
Cc: Vincent Fu <vincent.fu@xxxxxxxxxxx>, martin.petersen@xxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, gost.dev@xxxxxxxxxxx, Anuj Gupta <anuj20.g@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, mcgrof@xxxxxxxxxx, dlemoal@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20230811105300.15889-5-nj.shetty@samsung.com>
References: <20230811105300.15889-1-nj.shetty@samsung.com> <CGME20230811105713epcas5p3b5323a0c553006e60671dde6c72fc4c6@epcas5p3.samsung.com> <20230811105300.15889-5-nj.shetty@samsung.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 8/11/23 03:52, Nitesh Shetty wrote:

+	schedule_work(&emulation_io->emulation_work);

schedule_work() uses system_wq. This won't work for all users sincethere are no latency guarantees for system_wq.


Thanks,

Bart.

Follow-Ups:
- Re: [dm-devel] [PATCH v14 04/11] block: add emulation for copy
  - From: Nitesh Shetty

References:
- [PATCH v14 00/11] Implement copy offload support
  - From: Nitesh Shetty
- [PATCH v14 04/11] block: add emulation for copy
  - From: Nitesh Shetty