Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to
make sure we do not leak resources when something goes wrong. I run into this
while testing and all tests after the first failure failed then.
changes:
v3:
- added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
- removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
- added cleanup code to _nvmet_cleanup().
v2:
- updated commit messages
- moved the removal of subsys_name to the right patch
- added _nvmet_target_{setup|cleanup} helpers
this addresses also the 'appears unused' warning by ShellCheck
- https://lore.kernel.org/linux-nvme/20230810111317.25273-1-dwagner@xxxxxxx/
v1:
- initial version
https://lore.kernel.org/linux-nvme/20230726124644.12619-1-dwagner@xxxxxxx/
*** BLURB HERE ***
Daniel Wagner (13):
nvme/{003,004,005,013,046,049}: Group all variables declarations
nvme: Reorganize test preamble code section
nvme/043: Use hostnqn to generate DHCAP key
nvme/rc: Add common subsystem nqn define
nvme: Use def_subsysnqn variable instead local variable
nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and
hostid
nvme/rc: Add common file_path name define
nvme: Use def_file_path variable instead local variable
nvme/rc: Add common def_subsys_uuid define
nvme: Use def_subsys_uuid variable
nvme/rc: Add helper for adding/removing to allow list
nvme: Add explicitly host to allow_host list
nvme: Introduce nvmet_target_{setup/cleanup} common code
tests/nvme/003 | 12 ++-----
tests/nvme/004 | 23 ++++--------
tests/nvme/005 | 22 +++---------
tests/nvme/006 | 21 ++---------
tests/nvme/007 | 19 ++--------
tests/nvme/008 | 26 +++-----------
tests/nvme/009 | 21 +++--------
tests/nvme/010 | 26 +++-----------
tests/nvme/011 | 22 +++---------
tests/nvme/012 | 26 +++-----------
tests/nvme/013 | 22 +++---------
tests/nvme/014 | 26 +++-----------
tests/nvme/015 | 21 +++--------
tests/nvme/016 | 17 +++++----
tests/nvme/017 | 26 ++++++--------
tests/nvme/018 | 21 +++--------
tests/nvme/019 | 26 +++-----------
tests/nvme/020 | 21 +++--------
tests/nvme/021 | 21 +++--------
tests/nvme/022 | 21 +++--------
tests/nvme/023 | 26 +++-----------
tests/nvme/024 | 21 +++--------
tests/nvme/025 | 21 +++--------
tests/nvme/026 | 21 +++--------
tests/nvme/027 | 20 +++--------
tests/nvme/028 | 20 +++--------
tests/nvme/029 | 26 +++-----------
tests/nvme/030 | 19 +++++-----
tests/nvme/031 | 14 ++++----
tests/nvme/033 | 9 ++---
tests/nvme/034 | 9 ++---
tests/nvme/035 | 9 ++---
tests/nvme/036 | 9 ++---
tests/nvme/037 | 8 ++---
tests/nvme/038 | 6 ++--
tests/nvme/039 | 4 +--
tests/nvme/040 | 28 +++++----------
tests/nvme/041 | 49 ++++++++-----------------
tests/nvme/042 | 55 ++++++++++------------------
tests/nvme/043 | 52 +++++++++------------------
tests/nvme/044 | 71 ++++++++++++++----------------------
tests/nvme/045 | 62 ++++++++++++--------------------
tests/nvme/046 | 1 +
tests/nvme/047 | 30 ++++------------
tests/nvme/048 | 42 +++++++---------------
tests/nvme/049 | 1 +
tests/nvme/rc | 97 +++++++++++++++++++++++++++++++++++++++++++++++---
47 files changed, 404 insertions(+), 766 deletions(-)
--
2.41.0
