Re: [PATCH -next] ublk: Fix signedness bug returning warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 10, 2023 at 04:48:36PM +0800, Li Zetao wrote:
> There are two warnings reported by smatch:
> 
> drivers/block/ublk_drv.c:445 ublk_setup_iod_zoned() warn:
> 	signedness bug returning '(-95)'
> drivers/block/ublk_drv.c:963 ublk_setup_iod() warn:
> 	signedness bug returning '(-5)'
> 
> The type of "blk_status_t" is either be a u32 or u8, but this two
> functions return a negative value when not supported or failed. Use
> the error code of the blk module to fix these warnings.
> 
> Fixes: 29802d7ca33b ("ublk: enable zoned storage support")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/r/202308100201.TCRhgdvN-lkp@xxxxxxxxx/
> Signed-off-by: Li Zetao <lizetao1@xxxxxxxxxx>

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>

thanks,
Ming




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux