On Wed, 09 Aug 2023 22:59:47 +0200 Johannes Berg wrote: > On Wed, 2023-08-09 at 11:26 -0700, Jakub Kicinski wrote: > > Only three families use info->userhdr and fixed headers > > are discouraged for new families. So remove the pointer > > from struct genl_info to save some space. Compute > > the header pointer at runtime. Saved space will be used > > for a family pointer in later patches. > > Seems fine to me, but I'm not sure I buy the rationale that it's for > saving space - it's a single pointer on the stack? I'd probably argue > the computation being pointless for basically everyone except for a > handful users? Fair, I'll update all the commit messages. > Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Thanks!