On Tue, Aug 08, 2023 at 10:46:46AM +0200, Daniel Wagner wrote: > On Fri, Aug 04, 2023 at 06:33:04PM +0800, Yi Zhang wrote: > > On Tue, Aug 1, 2023 at 7:28 PM Yi Zhang <yi.zhang@xxxxxxxxxx> wrote: > > > After some investigating, I found it was due to the /dev/nvme0n1 node > > > couldn't be created in time which lead to the following fio failing. > > > + nvme connect -t tcp -a 127.0.0.1 -s 4420 -n blktests-subsystem-1 > > > --hostnqn=nqn.2014-08.org.nvmexpress:uuid:0f01fb42-9f7f-4856-b0b3-51e60b8de349 > > > --hostid=0f01fb42-9f7f-4856-b0b3-51e60b8de349 --nr-write-queues=1 > > > + ls -l /dev/nvme0 /dev/nvme-fabrics > > > crw-------. 1 root root 234, 0 Aug 1 05:50 /dev/nvme0 > > > crw-------. 1 root root 10, 122 Aug 1 05:50 /dev/nvme-fabrics > > > + '[' '!' -b /dev/nvme0n1 ']' > > > + echo '/dev/nvme0n1 node still not created' > > > dmesg: > > > [ 1840.413396] loop0: detected capacity change from 0 to 10485760 > > > [ 1840.934379] nvmet: adding nsid 1 to subsystem blktests-subsystem-1 > > > [ 1841.018766] nvmet_tcp: enabling port 0 (127.0.0.1:4420) > > > [ 1846.782615] nvmet: creating nvm controller 1 for subsystem > > > blktests-subsystem-1 for NQN > > > nqn.2014-08.org.nvmexpress:uuid:0f01fb42-9f7f-4856-b0b3-51e60b8de349. > > > [ 1846.808392] nvme nvme0: creating 33 I/O queues. > > > [ 1846.874298] nvme nvme0: mapped 1/32/0 default/read/poll queues. > > > [ 1846.945334] nvme nvme0: new ctrl: NQN "blktests-subsystem-1", addr > > > 127.0.0.1:4420 > > Not really sure how the blk device registration code works, but this > looks like there something executed not in the same context as the > nvme-cli command and thus we might return to userspace before the device > is fully created. And there is also udev events which are handled by > systemd. If this is the case, we might want to add some generic helper > which waits for the device to pop up before we continue with the test. After looking a bit at nvme/010 I see why does tests are not failing in the same way as nvme/047. After connecting _find_nvme_dev is used to wait for the device to appear: + nvme connect -t tcp -n blktests-subsystem-1 -a 127.0.0.1 -s 4420 --hostnqn=nqn.2014-08.org.nvmexpress:uuid:0f01fb42-9f7f-4856-b0b3-51e60b8de349 --hostid=0f01fb42-9f7f-4856-b0b3-51e60b8de349 ++ _find_nvme_dev blktests-subsystem-1 ++ local subsys=blktests-subsystem-1 ++ local subsysnqn ++ local dev ++ for dev in /sys/class/nvme/nvme* ++ '[' -e /sys/class/nvme/nvme0 ']' +++ basename /sys/class/nvme/nvme0 ++ dev=nvme0 +++ cat /sys/class/nvme/nvme0/subsysnqn ++ subsysnqn=nqn.2019-08.org.qemu:nvme-0 ++ [[ nqn.2019-08.org.qemu:nvme-0 == \b\l\k\t\e\s\t\s\-\s\u\b\s\y\s\t\e\m\-\1 ]] ++ for dev in /sys/class/nvme/nvme* ++ '[' -e /sys/class/nvme/nvme1 ']' +++ basename /sys/class/nvme/nvme1 ++ dev=nvme1 +++ cat /sys/class/nvme/nvme1/subsysnqn ++ subsysnqn=blktests-subsystem-1 ++ [[ blktests-subsystem-1 == \b\l\k\t\e\s\t\s\-\s\u\b\s\y\s\t\e\m\-\1 ]] ++ echo nvme1 ++ (( i = 0 )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) ++ [[ -e /sys/block/nvme1/uuid ]] ++ sleep .1 ++ (( i++ )) ++ (( i < 10 )) + nvmedev=nvme1 + cat /sys/block/nvme1n1/uuid 91fdba0d-f87b-4c25-b80f-db7be1418b9e + cat /sys/block/nvme1n1/wwid uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e We should propably do the same for all tests.
