On 2023/8/9 1:36, Jens Axboe wrote: > On 8/8/23 3:01 AM, Ruan Jinjie wrote: >> The drbd_destroy_device() arg of this code is already duplicated >> 18 times, use helper function put_drbd_dev() to release drbd_device >> and related resources instead of open coding it to help improve >> code readability a bit. >> >> And add get_drbd_dev() helper function to be symmetrical with it. >> >> No functional change involved. > > IMHO this just makes the code harder to read. You're not adding a > helper, all it does is call the same get/put parts. Why not just keep > it as-is then? Sorry, I misunderstood the meaning of a helper.I'll learn more about what other helper patches are doing. It's okay to keep it as it is. >
