On Aug 04, 2023 / 14:55, Hannes Reinecke wrote:
> On 8/4/23 14:20, Shin'ichiro Kawasaki wrote:
> > When test target is a zoned block device with max_active_zones limit
> > larger than max_open_zones, fio write operation may fail depending on
> > zone conditions. To avoid the failure, reset zones of the device before
> > the fio run.
> >
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> > ---
> > tests/block/004 | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/block/004 b/tests/block/004
> > index 63484a4..52a260f 100755
> > --- a/tests/block/004
> > +++ b/tests/block/004
> > @@ -15,7 +15,10 @@ requires() {
> > }
> > device_requires() {
> > - ! _test_dev_is_zoned || _have_fio_zbd_zonemode
> > + if _test_dev_is_zoned; then
> > + _have_fio_zbd_zonemode
> > + _have_program blkzone
> > + fi
> > }
> What would be the return value here?
> Do we care?
> Should we make it explicit?
No, we no longer care the return value. In the past, return values from
*requires() mattered until the commit 4824ac3f5c4a ("Skip tests based on
SKIP_REASON, not return value"). Instead of the return values, SKIP_REASON
were referred to judge test case skips.
After that, the commit 5c2012764cbc ("common, tests: Print multiple skip
reasons") renamed SKIP_REASON to SKIP_REASONS. These changes are reflected
in the descriptions in the "./new" script.
