On 04.08.23 12:12, Andreas Hindborg (Samsung) wrote: > > Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx> writes: > >> On 03.08.23 16:09, Andreas Hindborg (Samsung) wrote: >>> + buf = __vmalloc(bufsize, GFP_KERNEL | __GFP_NORETRY); >> >> Missing #include <linux/vmalloc.h> so the bot doesn't complain. > > Thanks, gotta add that so code compiles for Sega Dreamcast! > >> But while we're at it, why can't you just use kvmalloc() here? > > I don't see why not. It should be better for small reports I guess. I will change it. Yep, that way you won't need vmalloc.h either. The double underscore versions of a function are always a red flag when reviewing code to me.
