Niklas Cassel <Niklas.Cassel@xxxxxxx> writes: > On Fri, Jul 14, 2023 at 09:25:10AM +0200, Andreas Hindborg wrote: >> From: Andreas Hindborg <a.hindborg@xxxxxxxxxxx> > > Hello Andreas! > <snip> >> /* for READ request, writing data in iod->addr to rq buffers */ >> @@ -1120,6 +1404,11 @@ static void ublk_commit_completion(struct ublk_device *ub, >> /* find the io request and complete */ >> req = blk_mq_tag_to_rq(ub->tag_set.tags[qid], tag); >> >> + if (io->flags & UBLK_IO_FLAG_ZONE_APPEND) { > > Do we really need to introduce a completely new flag just for this? > > if (req_op(req) == REQ_OP_ZONE_APPEND) > > should work just as well, no? Makes sense, thanks. BR Andreas