On Mon, Jul 31, 2023 at 09:54:59PM +0900, Jinyoung Choi wrote: > The bio_integrity_add_page() returns the set length if the execution > result is successful. Otherwise, return 0. > > Unnecessary if statement was removed. And when the result value was less > than the set value, it was changed to failed. Maybe word this as bio_integrity_add_page() returns the add length if successful, else 0, just as bio_add_page. Simply check return value checking in bio_integrity_prep to not deal with a > 0 but < len case that can't happen. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>