There are voices that blktests changes through GitHub pull requests are not visible to relevant block sub-system kernel developers who communicate through linux-block mailing list. Some GitHub pull requests in the past needed additional discussion in the linux-block mailing list again to confirm that the changes were good for the kernel developers. To reduce the repeated discussion in the mailing list and GitHub, clarify that contribution by patch post to linux-block is preferred to GitHub pull request. Still GitHub pull requests are open mainly for quick, minor fixes. Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> --- CONTRIBUTING.md | 14 ++++++++------ README.md | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fd232b7..74d9771 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,11 +1,13 @@ # Contributing to blktests -You can contribute to blktests by opening a pull request to the [blktests -GitHub repository](https://github.com/osandov/blktests) or by sending patches -to the <linux-block@xxxxxxxxxxxxxxx> mailing list and Shin'ichiro Kawasaki -<shinichiro.kawasaki@xxxxxxx>. If sending patches, please generate the patch with `git -format-patch --subject-prefix="PATCH blktests"`. Consider configuring git to do -this for you with `git config --local format.subjectPrefix "PATCH blktests"`. +You can contribute to blktests by sending patches to the +<linux-block@xxxxxxxxxxxxxxx> mailing list and Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> +or by opening a pull request to the [blktests GitHub +repository](https://github.com/osandov/blktests). Patch post is more recommended +since it will be visible to more kernel developers and easier to gather +feedback. If sending patches, please generate the patch with `git format-patch +--subject-prefix="PATCH blktests"`. Consider configuring git to do this for you +with `git config --local format.subjectPrefix "PATCH blktests"`. All commits must be signed off (i.e., `Signed-off-by: Jane Doe <janedoe@xxxxxxxxxxx>`) as per the [Developer Certificate of Origin](https://developercertificate.org/). diff --git a/README.md b/README.md index 1324159..201d11c 100644 --- a/README.md +++ b/README.md @@ -54,5 +54,5 @@ referred as a document. It describes variables and functions that test cases should implement, global variables that test cases can refer and coding guidelines. -Pull requests on GitHub and patches to <linux-block@xxxxxxxxxxxxxxx> are both +Patches to <linux-block@xxxxxxxxxxxxxxx> and pull requests on GitHub are both accepted. See [here](CONTRIBUTING.md) for more information on contributing. -- 2.40.1
