On Wed, Jul 26, 2023 at 03:12:16PM -0700, Justin Tee wrote: > Hi Ming, > > From version 1 of the patchset, I thought we had planned to put the > min comparison right above pci_alloc_irq_vectors instead? > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 3221a934066b..20410789e8b8 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -13025,6 +13025,8 @@ lpfc_sli4_enable_msix(struct lpfc_hba *phba) > flags |= PCI_IRQ_AFFINITY; > } > > + vectors = min_t(unsigned int, vectors, scsi_max_nr_hw_queues()); Strictly speaking, the above change is better, but non-managed irq doesn't have such issue, that is why I just apply the change on managed irq branch. Thanks, Ming
