Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations

To: Daniel Wagner <dwagner@xxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 26 Jul 2023 07:54:24 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Chaitanya Kulkarni <kch@xxxxxxxxxx>, "Shin'ichiro Kawasaki" <shinichiro.kawasaki@xxxxxxx>, Max Gurtovoy <mgurtovoy@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, James Smart <jsmart2021@xxxxxxxxx>
In-reply-to: <20230726124644.12619-2-dwagner@suse.de>
References: <20230726124644.12619-1-dwagner@suse.de> <20230726124644.12619-2-dwagner@suse.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0

On 7/26/23 05:46, Daniel Wagner wrote:

Group all variable declarations together at the beginning of the
function.

An explanation of why this change has been proposed is missing from thepatch description.

I think the current style, with variable declarations occurring justbefore the first use of a variable, is on purpose. I like that style.


Bart.

Follow-Ups:
- Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
  - From: Daniel Wagner

References:
- [PATCH blktests v1 00/11] Switch to allowed_host
  - From: Daniel Wagner
- [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
  - From: Daniel Wagner