On 03/27/2017 01:00 PM, Shaohua Li wrote: > On Mon, Mar 27, 2017 at 12:15:29PM -0600, Jens Axboe wrote: >> On 03/27/2017 11:51 AM, Shaohua Li wrote: >>> V6->V7: >>> - Don't overload blk stat, which will simplify the code. This will add extra >>> space in bio/request though with the low interface configure option on. >> >> Hmm, why? As far as I can see, it just makes things worse. > > Part of the reason is the new callback based blk stat makes enabling stat less > straightforward. I probably can create a fake callback and enalbing the stat > though. Only the last 3 patches depend on this, if you prefer, I can resend > them and add the overload back. Yeah, I think that would be a big improvement. -- Jens Axboe
