Re: [PATCH v2 02/10] qcom_scm: scm call for deriving a software secret

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 21, 2023 at 09:18:24PM -0700, Eric Biggers wrote:
> On Fri, Jul 21, 2023 at 08:50:56PM -0700, Bjorn Andersson wrote:
> > > +/**
> > > + * qcom_scm_derive_sw_secret() - Derive SW secret from wrapped key
> > > + * @wrapped_key: the wrapped key used for inline encryption
> > > + * @wrapped_key_size: size of the wrapped key
> > 
> > Following my reply on patch 7, how about dropping the "_key" suffix on
> > these.
> > 
> > > + * @sw_secret: the secret to be derived which is exactly the secret size
> > 
> > Similarly the "sw_" prefix doesn't see to add value, please omit it.
> 
> The name 'sw_secret' comes from the block layer support
> (https://lore.kernel.org/linux-block/20221216203636.81491-2-ebiggers@xxxxxxxxxx/).
> It is helpful to call it 'sw_secret' instead of 'secret', as there are other
> types of secrets involved that are not accessible to software (Linux).
> 

I'm happy with that motivation.

My OCD would like for the length of that to be sw_secret_size (or
perhaps _len instead...), and not "secret_size", then.

Thanks Eric,
Bjorn



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux