On Wed, Jul 12, 2023 at 06:23:10PM +0200, Christoph Hellwig wrote: > On Mon, Jul 10, 2023 at 06:42:36PM +0800, Ming Lei wrote: > > Userspace may write 0 to discard_max_bytes, and this patch still can > > override user setting. > > True. Maybe the right thing is to have a user_limit field, and just > looks at the min of that and the hw limit everywhere. These hardware > vs user limits are a pain, and we'll probably need some proper > infrastructure for them :P Yeah, I had to do something very similiar for the max_sectors limit too: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=c9c77418a98273fe96835c42666f7427b3883f48
