On 2023/7/11 19:31, Christoph Hellwig wrote: > On Tue, Jul 11, 2023 at 07:06:20PM +0800, Chengming Zhou wrote: >> Ok, will add a Fixes tag and send it as a separate patch since it's a bug fix. > > Btw, it's probably not worth resending patch 2 until we've figured out > and dealt with the SATA flush regression that Chuck reported. Ok, I will not resend patch 2. As for the patch 1, should I resend it as a separate patch or just put it in that series [1] before other flush optimizations ? I search on the block mail list, find the issue [2] you mentioned, will look into it too. [1] https://lore.kernel.org/lkml/20230707093722.1338589-1-chengming.zhou@xxxxxxxxx/ [2] https://lore.kernel.org/linux-block/7A57C7AE-A51A-4254-888B-FE15CA21F9E9@xxxxxxxxxx/