On Mon, Jul 10, 2023 at 12:57:56PM +0900, Damien Le Moal wrote: > On 7/7/23 18:46, Christoph Hellwig wrote: > > ctrl->max_discard_sectors stores a value that is potentially based of > > the DMRSL field in Identify Controller, which is in units of LBAs and > > thus dependent on the Format of a namespace. > > > > Fix this by moving the calculation of max_discard_sectors entirely > > into nvme_config_discard and replacing the ctrl->max_discard_sectors > > value with a local variable so that the calculation is always > > I do not see a local variable replacement... May be you meant direct calls to > blk_queue_max_discard_sectors() ? Yeah, I used a local variable first, but then noticed they are pointless as we can just call blk_queue_max_discard_sectors directly and didn't update the commit log.
