On 7/6/23 3:27?AM, ???(wink) wrote: >>>> Mq-deadline would store request in list:fifo_list and >>>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which >>>> is beneficial for understanding. > >>> Huh? I think this patch makes the code less readable instead of more readable ... > >> Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort' >> So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader. > > Hi Sir? > Should it be merged for the above reason? Hope for your reply, thanks. No, the patch makes no sense. I agree with Bart that it doesn't make it any more readable, in fact it's worse. We have a sort and fifo list, the backing data structure isn't that exciting by itself. -- Jens Axboe
