On Wed, Jul 05, 2023 at 07:35:22PM +0900, Shin'ichiro Kawasaki wrote:
> When ublk_drv driver is not a loadable module but a built-in module,
> modprobe for the driver fails in _init_ublk. This results in unexpected
> test case skips with the message "requires ublk_drv".
>
> To not skip the test cases with built-in ublk_drv, call modprobe only
> when the driver is loadable and its module file exists. Also, do not set
> SKIP_REASONS to handle modprobe failure as test case failure.
>
> Fixes: 840ccf1fc33e ("block/033: add test to cover gendisk leak")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
Thanks,
Ming
