On 6/29/23 18:17, Andreas Hindborg (Samsung) wrote: > > Ming Lei <ming.lei@xxxxxxxxxx> writes: > >> On Wed, Jun 28, 2023 at 09:06:49PM +0200, Andreas Hindborg wrote: >>> From: Andreas Hindborg <a.hindborg@xxxxxxxxxxx> >>> >>> Add zone append feature to ublk. This feature uses the `addr` field of `struct >>> ublksrv_io_cmd`. Therefore ublk must be used with the user copy >>> feature (UBLK_F_USER_COPY) for zone append to be available. Without this >>> feature, ublk will fail zone append requests. >> >> Given zone append is a must, please fail to add device in case of zoned >> and !user_copy, then we can make fast IO code path clean. > > I will squash the patches and reject zone support if not user copy is > enabled 👍 Or if !CONFIG_BLK_DEV_ZONED or if the user specifies a bad parameter (invalid limits etc). -- Damien Le Moal Western Digital Research
