On 6/29/23 10:04, Yu Kuai wrote: > Hi, > > 在 2023/06/29 1:07, Min Li 写道: >> On Mon, Jun 28, 2023 at 04:48:36PM +0000, Christoph Hellwig wrote: >>> They are long long in the UAPI, which is weird but has been that way >>> for a long time. So I think we need checks for negative values >>> before they are shifted and converted to a sector_t. >> >> Do you mean that we need to check if p.start and p.length are negative? >> > > Perhaps this patch will make sense. > > https://lore.kernel.org/all/20230525072041.3701176-1-zhongjinghua@xxxxxxxxxx/ + adding to it the logical block size alignment checks. > > Thanks, > Kuai >> Thanks for your reply >> >> Min li >> . >> > -- Damien Le Moal Western Digital Research