On 6/28/2023 1:09 AM, Max Gurtovoy wrote: > > > On 28/06/2023 10:24, Sagi Grimberg wrote: >> >>>> Yi, >>>> >>>> Do you have hostnqn and hostid files in your /etc/nvme directory? >>>> >>> >>> No, only one discovery.conf there. >>> >>> # ls /etc/nvme/ >>> discovery.conf >> >> So the hostid is generated every time if it is not passed. >> We should probably revert the patch and add it back when >> blktests are passing. > > Seems like the patch is doing exactly what it should do - fix wrong > behavior of users that override hostid. > Can we fix the tests instead ? I didn't find anything wrong with the Max's patch and more importantly blktests are still passing on my setup where it has required files, but Yi doesn't have those file as stated above :- nvme (nvme-6.5) # ls -l /etc/nvme/ total 12 -rw-r--r--. 1 root root 183 Jan 23 23:58 discovery.conf -rw-r--r--. 1 root root 37 Mar 16 2022 hostid -rw-r--r--. 1 root root 12 Mar 17 2022 hostnqn nvme (nvme-6.5) # Let's not revert Max's patch and fix the blktests. -ck
