On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote:
> Introduce queue_logical_block_mask() and bdev_logical_block_mask()
> to simplify code, which replace (queue_logical_block_size(q) - 1)
> and (bdev_logical_block_size(bdev) - 1).
>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
Looks fine.
Reviewed-by: Bill O'Donnell <bodonnel@xxxxxxxxxx>
> ---
> include/linux/blkdev.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index ed44a997f629..0cc0d1694ef6 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1150,11 +1150,21 @@ static inline unsigned queue_logical_block_size(const struct request_queue *q)
> return retval;
> }
>
> +static inline unsigned int queue_logical_block_mask(const struct request_queue *q)
> +{
> + return queue_logical_block_size(q) - 1;
> +}
> +
> static inline unsigned int bdev_logical_block_size(struct block_device *bdev)
> {
> return queue_logical_block_size(bdev_get_queue(bdev));
> }
>
> +static inline unsigned int bdev_logical_block_mask(struct block_device *bdev)
> +{
> + return bdev_logical_block_size(bdev) - 1;
> +}
> +
> static inline unsigned int queue_physical_block_size(const struct request_queue *q)
> {
> return q->limits.physical_block_size;
> --
> 2.39.0
>
