On Wed, Jun 28, 2023 at 01:09:41PM +0000, Min Li wrote: > + long long blksz = bdev_logical_block_size(bdev), start, length; long long for the blocksize is a bit weird here, as the value is an unsigned int. Also while pre-existing the long long for start/length looks weird, do we need to check for negative values somewhere? Also don't forget the Cc stable that Greg requested.