Hello, I only glanced the blk-mq core part but in general this looks a lot better than the previous one. On Mon, Jun 26, 2023 at 01:04:05PM +0800, chengming.zhou@xxxxxxxxx wrote: > Note we don't skip setting alloc_time_ns and start_time_ns for all > pre-allocated rq, since the first returned rq still need to be set. This part is a bit curious for me tho. Why do we need to set it at batch allocation time and then at actual dispensing from the bat later? Who uses the alloc time stamp inbetween? Thanks. -- tejun