Re: [PATCH v4 3/7] block: Send requeued requests to the I/O scheduler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/21/23 18:19, Damien Le Moal wrote:
Why ? I still do not understand the need for this. There is always only a single
in-flight write per sequential zone. Requeuing that in-flight write directly to
the dispatch list will not reorder writes and it will be better for the command
latency.
Hi Damien,

After having taken a closer look I see that blk_req_zone_write_unlock() is called from inside dd_insert_request() when requeuing a request. Hence, there is no reordering risk when requeuing a zoned write. I will drop this patch.

Do you agree with having one requeue list per hctx instead of per request queue? This change enables eliminating blk_mq_kick_requeue_list(). I think that's an interesting simplification of the block layer API.

Thanks,

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux