Re: [PATCH] blk-mq: don't insert passthrough request into sw queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/21/23 06:22, Ming Lei wrote:
  	percpu_ref_get(&this_hctx->queue->q_usage_counter);
  	/* passthrough requests should never be issued to the I/O scheduler */
-	if (this_hctx->queue->elevator && !is_passthrough) {
+	if (is_passthrough) {
+		spin_lock(&this_hctx->lock);
+		list_splice_tail_init(&list, &this_hctx->dispatch);
+		spin_unlock(&this_hctx->lock);
+		blk_mq_run_hw_queue(this_hctx, from_sched);
+	} else if (this_hctx->queue->elevator) {
  		this_hctx->queue->elevator->type->ops.insert_requests(this_hctx,
  				&list, 0);
  		blk_mq_run_hw_queue(this_hctx, from_sched);

The code change in this patch looks fine to me. However, with this patch applied the code and the source code comment just above the modified are now out of sync :-(

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux