On 6/21/23 00:30, Yu Kuai wrote: > Hi, > > 在 2023/06/21 15:02, Shinichiro Kawasaki 写道: >> CC+: Yu Kuai, linux-scsi, >> >> On Jun 21, 2023 / 02:46, Shinichiro Kawasaki wrote: >>> On Jun 20, 2023 / 06:11, Chaitanya Kulkarni wrote: >>>> Hi, >>>> >>>> I found few failures, are you also getting the same ? >>>> >>>> linux-block/for-next observed block test failure :- >>> >>> Yes, I've jtried the kernel on linux-block/for-next at git hash >>> 334bdb61bbea, >>> and see the same failure symptoms. It looks that the first test case >>> block/001 >>> left scsi_debug in weird status, and following test cases were >>> affected. >>> >>> I tried simple commands below and found that scsi_debug module >>> unload fails. >>> >>> # modprobe scsi_debug >>> # modprobe -r scsi_debug >>> modprobe: FATAL: Module scsi_debug is in use. > > Thanks for the test, this is because /dev/sg will grab reference for > scsi_device, and this will block remove module. > Please make sure to run the blktests in order to validate following change and add the result into cover-letter when you send a formal patch so it will be easier to give you review-by for everyone. -ck