On 6/20/23 12:18?AM, Christoph Hellwig wrote: > So it turns out this gets into the way of my planned cleanup to move > all the tatic FMODE_ flags out of this basically full field into a new > static one in file_operations. Do you think it is ok to go back to > always claiming FMODE_NOWAIT for block devices and then just punt for > the drivers that don't support it like the patch below? I think we need stronger justification than that, it's much nicer to have it in the open path than doing the same check over and over for each IO. With your new proposed scheme, why can't the check and FMODE_NOWAIT set still be in open? -- Jens Axboe
